Skip to content

add plugins/vscode folder and update vsix package scripts #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qdaxb wants to merge 1 commit into from
Closed

add plugins/vscode folder and update vsix package scripts #2596

qdaxb wants to merge 1 commit into from

Conversation

@qdaxb
Copy link
Contributor

@qdaxb qdaxb commented Apr 14, 2025 •
edited by ellipsis-dev bot
Loading

Context

According to the concept outlined in #2536, the initial implementation of steps 1 and 2 has been completed. The extension.js file and the packaging-related scripts have been moved to the plugins/vscode directory.

This is an initial attempt to explain the previous concept and to facilitate further discussion. Some commands may still require additional compatibility adjustments.

Implementation

  • Added a new plugins/vscode directory to manage all VSCode extension-related source code, configuration, and packaging scripts separately. Migrated the extension entry file and theme files into this directory.
  • Introduced and improved plugin-specific files such as package.json, package-lock.json, .gitignore, .vscodeignore, build.js, tsconfig.json, and scripts/postpack.js to support development, building, and packaging of the extension.
  • Updated .vscode/launch.json and .vscode/tasks.json to enable debugging and building the extension within the new directory, with relevant parameters and output paths pointing to plugins/vscode.
  • Removed the old esbuild.js from the project root, as the related build process has been migrated or is no longer needed.

use npm run build in root dir to build plugin, and the output will located in plugins/vscode/bin.

Screenshots

before after

How to Test

Get in Touch

Important

Reorganize VSCode extension files into plugins/vscode, update build scripts, and remove obsolete files.

  • Directory Structure:
    • Added plugins/vscode directory for VSCode extension-related files.
    • Moved extension.ts and theme files to plugins/vscode/src.
  • Build Process:
    • Introduced build.js in plugins/vscode for building the extension.
    • Updated package.json scripts to use new build process.
    • Removed esbuild.js from the root directory.
  • Configuration Files:
    • Added package.json, .gitignore, .vscodeignore in plugins/vscode.
    • Updated .vscode/launch.json and .vscode/tasks.json for new directory.
  • Miscellaneous:
    • Added postpack.js script in plugins/vscode/scripts for cleanup after packaging.

This description was created by Ellipsis for fe8f7cedde16197b937025067cc2a5445a6a8843. It will automatically update as commits are pushed.

@qdaxb qdaxb requested review from cte and mrubens as code owners April 14, 2025 11:40
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b365f0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Apr 14, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 14, 2025
@cte
Copy link
Collaborator

cte commented Apr 14, 2025

Is this ready for review? If so do you mind taking a look at the test failures?

@qdaxb qdaxb force-pushed the add_vscode_plugin_folder branch from fe8f7ce to fa5ebaf Compare April 15, 2025 05:55
@qdaxb qdaxb force-pushed the add_vscode_plugin_folder branch from fa5ebaf to b365f0e Compare April 15, 2025 06:54
@qdaxb
Copy link
Contributor Author

qdaxb commented Apr 15, 2025

Is this ready for review? If so do you mind taking a look at the test failures?

@cte I’ve resolved the test failure issue. I think we can first review the overall approach—if it looks good, then I’ll proceed to update the package.json.

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Needs Review] in Roo Code Roadmap May 26, 2025
@daniel-lxs
Copy link
Member

daniel-lxs commented Jun 4, 2025

Thanks for your contribution. We genuinely apologize for letting your PR get caught up in the messy state of our old PR process. You deserved better, and it's entirely our fault for taking so long.

We're closing this PR because we have made significant changes to the structure of the project, we migrated to a monorepo.

We've now shifted to a clearer issue-first workflow to avoid this kind of situation going forward. Please create an issue first for any future contributions, as outlined there.

We truly appreciate your patience and would be happy to have you continue contributing.

@daniel-lxs daniel-lxs closed this Jun 4, 2025
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Jun 4, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@cte cte Awaiting requested review from cte cte is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request PR - Needs Preliminary Review size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qdaxb @cte @daniel-lxs